Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converted slashcommands-mute coffee to js #6474

Merged
merged 2 commits into from
Mar 29, 2017
Merged

converted slashcommands-mute coffee to js #6474

merged 2 commits into from
Mar 29, 2017

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 24, 2017

@RocketChat/core

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-6474 March 27, 2017 21:24 Inactive
rodrigok
rodrigok requested changes Mar 28, 2017
View reviewed changes
packages/rocketchat-slashcommands-mute/server/mute.js Outdated
* Mute is a named function that will replace /mute commands
*/

const Mute = function Mute(command, params, item) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the const Mute?

packages/rocketchat-slashcommands-mute/server/mute.js Outdated
});
return;
}
if ((room.usernames || []).contains(username)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contains does not exists, the correct is includes

packages/rocketchat-slashcommands-mute/server/unmute.js Outdated
* Unmute is a named function that will replace /unmute commands
*/

const Unmute = function Unmute(command, params, item) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here :)

packages/rocketchat-slashcommands-mute/server/unmute.js Outdated
}, user.language)
});
}
if ((room.usernames || []).contains(username)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@engelgabriel engelgabriel merged commit 002d7cf into RocketChat:develop Mar 29, 2017
@engelgabriel engelgabriel added this to the 0.55.0 milestone Mar 29, 2017
@ggazzo ggazzo deleted the slashcommands-mute branch March 31, 2017 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.55.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ggazzo @rodrigok @engelgabriel @marceloschmidt